Issue 23701010: Switch to async_helper package.

Issue 23701010: Switch to async_helper package. (Closed)

Created:
7 years, 3 months ago by floitsch

Modified:
7 years, 3 months ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Switch to async_helper package. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26918

Patch Set 2 : Rebase and adapt 3 new tests. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -84 lines)			Patch
D	tests/async_helper.dart	View		1 chunk	+0 lines, -63 lines	0 comments	Download
M	tests/compiler/dart2js_extra/deferred/deferred_class_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/compiler/dart2js_extra/deferred/deferred_function_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/isolate/global_error_handler2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/global_error_handler_stream2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/illegal_msg_stream_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/illegal_msg_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/isolate2_negative_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/encoding_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/streamed_conversion_json_decode1_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/streamed_conversion_json_encode1_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/streamed_conversion_json_utf8_encode_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/streamed_conversion_utf8_decode_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/convert/streamed_conversion_utf8_encode_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/mirrors/invoke_private_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/mirrors/invoke_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/light_unittest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

CCing Peter, since there are some dart2js tests that have their own version of async_helper. ...

7 years, 3 months ago (2013-08-30 07:51:05 UTC) #1

kustermann

LGTM. I hope you caught all uses of it. https://codereview.chromium.org/23701010/diff/1/tests/isolate/global_error_handler2_test.dart File tests/isolate/global_error_handler2_test.dart (right): https://codereview.chromium.org/23701010/diff/1/tests/isolate/global_error_handler2_test.dart#newcode10 tests/isolate/global_error_handler2_test.dart:10: ...

7 years, 3 months ago (2013-08-30 14:00:16 UTC) #2

floitsch

https://codereview.chromium.org/23701010/diff/1/tests/isolate/global_error_handler2_test.dart File tests/isolate/global_error_handler2_test.dart (right): https://codereview.chromium.org/23701010/diff/1/tests/isolate/global_error_handler2_test.dart#newcode10 tests/isolate/global_error_handler2_test.dart:10: import "package:async_helper/async_helper.dart"; On 2013/08/30 14:00:16, kustermann wrote: > single ...

7 years, 3 months ago (2013-08-30 14:15:36 UTC) #3

floitsch

Committed patchset #2 manually as r26918 (presubmit successful).

7 years, 3 months ago (2013-08-30 14:20:18 UTC) #4

Message was sent while issue was closed.

Thank you, Florian.

Expand Messages | Collapse Messages