Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 23701005: Fix cc::Layer debug name (Closed)

Created:
7 years, 3 months ago by rharrison
Modified:
7 years, 3 months ago
Reviewers:
Ian Vollick, danakj
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Fix cc::Layer debug name Have ui::Layer subclass cc::LayerClient and register itself as the client of the cc::Layer it is using. This allows the names for the layers appear in debugging output. BUG=280662 TEST=Built version of chrome that dumps debug information about layers and confirmed the missing layer names are now present. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M cc/layers/layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/layer.cc View 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rharrison
vollick: This is the CL we were discussing yesterday danakj: vollick is on vacation, but ...
7 years, 3 months ago (2013-08-28 19:43:18 UTC) #1
danakj
LGTM
7 years, 3 months ago (2013-08-28 19:45:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rharrison@chromium.org/23701005/1
7 years, 3 months ago (2013-08-29 13:50:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=73963
7 years, 3 months ago (2013-08-29 19:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rharrison@chromium.org/23701005/1
7 years, 3 months ago (2013-08-29 19:14:34 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 02:13:34 UTC) #6
Message was sent while issue was closed.
Change committed as 220477

Powered by Google App Engine
This is Rietveld 408576698