Issue 23694025: Remove calls to deprecated session_manager DBus methods

Issue 23694025: Remove calls to deprecated session_manager DBus methods (Closed)

Created:
7 years, 3 months ago by Chris Masone

Modified:
7 years, 3 months ago

Reviewers:
Daniel Erat, oshima

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove calls to deprecated session_manager DBus methods RestartEntd() was deprecated years ago, so calls to this method can certainly be removed. The UnlockScreen() method has done nothing but emit a signal that no process listens to for several releases now. BUG=chromium:286401 TEST=unit tests, desktopui_ScreenLocker autotest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222227

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -86 lines)			Patch
M	chrome/browser/chromeos/enterprise_extension_observer.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View	1 2 3	5 chunks	+5 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker_browsertest.cc	View	1	2 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker_tester.cc	View	1 2 3	4 chunks	+12 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/power/screen_lock_observer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/power/screen_lock_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/settings/device_settings_test_helper.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/settings/device_settings_test_helper.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/fake_session_manager_client.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/dbus/fake_session_manager_client.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chromeos/dbus/mock_session_manager_client.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/dbus/session_manager_client.h	View		3 chunks	+0 lines, -11 lines	0 comments	Download
M	chromeos/dbus/session_manager_client.cc	View		6 chunks	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

Oshima, can you look at the screen-locker-related changes? Dan, please check over the rest.

7 years, 3 months ago (2013-09-09 16:53:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/23694025/20001

7 years, 3 months ago (2013-09-09 23:57:24 UTC) #4

Message was sent while issue was closed.

Change committed as 222227

Expand Messages | Collapse Messages