Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 23694022: Fixes bug where reposted events had wrong root coordinates (Closed)

Created:
7 years, 3 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fixes bug where reposted events had wrong root coordinates Reposting happens when a menu is running and you click outside the menu. The code was not setting the root_location of the newly created event, resulting in anyone attempting to use the root (such as the app list) getting the wrong thing. BUG=285662 TEST=see bug R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/event_utils_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
7 years, 3 months ago (2013-09-05 23:32:45 UTC) #1
sadrul
lgtm
7 years, 3 months ago (2013-09-05 23:33:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23694022/1
7 years, 3 months ago (2013-09-05 23:45:11 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76079
7 years, 3 months ago (2013-09-06 09:07:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23694022/1
7 years, 3 months ago (2013-09-06 16:14:12 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 17:57:30 UTC) #6
Message was sent while issue was closed.
Change committed as 221735

Powered by Google App Engine
This is Rietveld 408576698