Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: sync/engine/commit.cc

Issue 23694004: sync: Remove IDs from OrderedCommitSet (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/build_commit_command.cc ('k') | sync/engine/get_commit_ids_command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/commit.cc
diff --git a/sync/engine/commit.cc b/sync/engine/commit.cc
index ee69812c3f9eed6b774bc5bd980410d954fa4d25..f7f1e74d99e0789eeeef0771ae7c23e5d2137a07 100644
--- a/sync/engine/commit.cc
+++ b/sync/engine/commit.cc
@@ -26,10 +26,10 @@ namespace {
void SetAllSyncingBitsToValue(WriteTransaction* trans,
const sessions::OrderedCommitSet& commit_set,
bool value_to_set) {
- const std::vector<syncable::Id>& commit_ids = commit_set.GetAllCommitIds();
- for (std::vector<syncable::Id>::const_iterator it = commit_ids.begin();
- it != commit_ids.end(); ++it) {
- syncable::MutableEntry entry(trans, syncable::GET_BY_ID, *it);
+ const std::vector<int64>& commit_handles = commit_set.GetAllCommitHandles();
+ for (std::vector<int64>::const_iterator it = commit_handles.begin();
+ it != commit_handles.end(); ++it) {
+ syncable::MutableEntry entry(trans, syncable::GET_BY_HANDLE, *it);
if (entry.good()) {
entry.Put(syncable::SYNCING, value_to_set);
}
« no previous file with comments | « sync/engine/build_commit_command.cc ('k') | sync/engine/get_commit_ids_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698