Issue 23693004: Change Mac Video Capture format change ARGB->YUY2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23693004: Change Mac Video Capture format change ARGB->YUY2 (Closed)

Created:
7 years, 3 months ago by mcasas

Modified:
7 years, 3 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Mac Video Capture format change ARGB->YUY2. Using RGBA implies a colour space conversion in the driver from YUY2 (native capture) to RGBA, which is undone in VideoCaptureController, RGBA to YUV I420. Avoiding this double conversion uses about 5% less CPU in the CMIO thread. BUG=285967 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222250

Patch Set 1 #

Patch Set 2 : MacOsSDK 10.6 not supporting YUYV, changed to UYVY, added it to VideoCaptureController #

Patch Set 3 : Corrected the CVPixelFormat to UYUV #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
M	content/browser/renderer_host/media/video_capture_controller.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	media/video/capture/mac/video_capture_device_mac.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	media/video/capture/mac/video_capture_device_qtkit_mac.mm	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

lgtm. Can you add some more info on why you're doing this to the cl ...

7 years, 3 months ago (2013-09-08 19:19:06 UTC) #2

mcasas

Hi tommi, there has been some iteration on the CL, since the Mac bots did ...

7 years, 3 months ago (2013-09-10 05:51:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/23693004/11001

7 years, 3 months ago (2013-09-10 07:11:19 UTC) #5

Message was sent while issue was closed.

Change committed as 222250

Expand Messages | Collapse Messages