Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 23691074: ui/compositor: use an IO message loop on posix instead of DEFAULT (Closed)

Created:
7 years, 3 months ago by piman
Modified:
7 years, 3 months ago
Reviewers:
danakj, marcheu
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

ui/compositor: use an IO message loop on posix instead of DEFAULT MessagePumpDefault breaks PostDelayedTask on posix because it uses system time. MessagePumpIO uses monotonic time, so is immune to these problems. BUG=293736, chrome-os-partner:22627 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ui/compositor/compositor.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
piman
7 years, 3 months ago (2013-09-18 01:18:26 UTC) #1
marcheu
On 2013/09/18 01:18:26, piman wrote: I tested it on the device, and it fixes the ...
7 years, 3 months ago (2013-09-18 03:42:55 UTC) #2
danakj
LGTM should we do the same in render_thread_impl.cc EnsureWebKitInitialized()?
7 years, 3 months ago (2013-09-18 13:26:25 UTC) #3
piman
On 2013/09/18 13:26:25, danakj wrote: > LGTM should we do the same in render_thread_impl.cc EnsureWebKitInitialized()? ...
7 years, 3 months ago (2013-09-18 19:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/23691074/1
7 years, 3 months ago (2013-09-18 19:31:00 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 22:19:32 UTC) #6
Message was sent while issue was closed.
Change committed as 223961

Powered by Google App Engine
This is Rietveld 408576698