Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/renderer/media/webrtc_logging_message_filter.cc

Issue 23691066: Hook up WebRTC logging extension API to the underlying functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/media/webrtc_logging_message_filter.h ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/media/webrtc_logging_message_filter.cc
diff --git a/chrome/renderer/media/webrtc_logging_message_filter.cc b/chrome/renderer/media/webrtc_logging_message_filter.cc
index 6475ea30710b6793326981b93f96ed5418d8444a..f2370defd9dc8b8257f4b959d908e67d48a548b6 100644
--- a/chrome/renderer/media/webrtc_logging_message_filter.cc
+++ b/chrome/renderer/media/webrtc_logging_message_filter.cc
@@ -32,8 +32,8 @@ bool WebRtcLoggingMessageFilter::OnMessageReceived(
DCHECK(io_message_loop_->BelongsToCurrentThread());
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(WebRtcLoggingMessageFilter, message)
- IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_LogOpened, OnLogOpened)
- IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_OpenLogFailed, OnOpenLogFailed)
+ IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_StartLogging, OnStartLogging)
+ IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_StopLogging, OnStopLogging)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -56,11 +56,9 @@ void WebRtcLoggingMessageFilter::OnChannelClosing() {
log_message_delegate_->OnFilterRemoved();
}
-void WebRtcLoggingMessageFilter::InitLogging(
- const std::string& app_session_id,
- const std::string& app_url) {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- Send(new WebRtcLoggingMsg_OpenLog(app_session_id, app_url));
+void WebRtcLoggingMessageFilter::LoggingStopped() {
+ DCHECK(io_message_loop_->BelongsToCurrentThread());
+ Send(new WebRtcLoggingMsg_LoggingStopped());
}
void WebRtcLoggingMessageFilter::CreateLoggingHandler() {
@@ -69,16 +67,16 @@ void WebRtcLoggingMessageFilter::CreateLoggingHandler() {
new ChromeWebRtcLogMessageDelegate(io_message_loop_, this);
}
-void WebRtcLoggingMessageFilter::OnLogOpened(
+void WebRtcLoggingMessageFilter::OnStartLogging(
base::SharedMemoryHandle handle,
uint32 length) {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- log_message_delegate_->OnLogOpened(handle, length);
+ log_message_delegate_->OnStartLogging(handle, length);
}
-void WebRtcLoggingMessageFilter::OnOpenLogFailed() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- log_message_delegate_->OnOpenLogFailed();
+void WebRtcLoggingMessageFilter::OnStopLogging() {
+ DCHECK(io_message_loop_->BelongsToCurrentThread());
+ log_message_delegate_->OnStopLogging();
}
void WebRtcLoggingMessageFilter::Send(IPC::Message* message) {
« no previous file with comments | « chrome/renderer/media/webrtc_logging_message_filter.h ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698