content/renderer/media/webrtc_logging_initializer.h - Issue 23691066: Hook up WebRTC logging extension API to the underlying functionality.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/media/webrtc_logging_initializer.h

Issue 23691066: Hook up WebRTC logging extension API to the underlying functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: First patch ready for review. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/renderer/media/media_stream_dependency_factory.cc ('K') | « content/renderer/media/media_stream_dependency_factory.cc ('k') | content/renderer/media/webrtc_logging_initializer.cc » ('j') | content/renderer/media/webrtc_logging_initializer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_RENDERER_WEBRTC_LOGGING_INITIALIZER_H_	5 #ifndef CONTENT_RENDERER_WEBRTC_LOGGING_INITIALIZER_H_

6 #define CONTENT_RENDERER_WEBRTC_LOGGING_INITIALIZER_H_	6 #define CONTENT_RENDERER_WEBRTC_LOGGING_INITIALIZER_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 namespace content {	10 namespace content {

11	11

12 class WebRtcLogMessageDelegate;	12 class WebRtcLogMessageDelegate;

13	13

14 // Must be called on IO thread.

15 void InitWebRtcLogging(const std::string& app_session_id,

16 const std::string& app_url);

17

18 // May be called on any thread.	14 // May be called on any thread.

19 void WebRtcLogMessage(const std::string& message);	15 void WebRtcLogMessage(const std::string& message);
no longer working on chromium 2013/10/01 08:41:42 It looks odd to have the initializer being used as It looks odd to have the initializer being used as a dispatcher to forward the error message, why this file is needed? can you merge the method to other file, like chrome_webrtc_log_message_delegate.cc? Henrik Grunell 2013/10/02 12:47:18 There was quite a long discussion about this with Show quoted text On 2013/10/01 08:41:42, xians1 wrote: > It looks odd to have the initializer being used as a dispatcher to forward the > error message, why this file is needed? can you merge the method to other file, > like chrome_webrtc_log_message_delegate.cc? There was quite a long discussion about this with jam@, joi@ and tommi@. I can give you details off-review if you like. no longer working on chromium 2013/10/02 12:55:10 All right, just keep what it is if that is some ki Show quoted text On 2013/10/02 12:47:18, Henrik Grunell wrote: > On 2013/10/01 08:41:42, xians1 wrote: > > It looks odd to have the initializer being used as a dispatcher to forward the > > error message, why this file is needed? can you merge the method to other > file, > > like chrome_webrtc_log_message_delegate.cc? > > There was quite a long discussion about this with jam@, joi@ and tommi@. I can > give you details off-review if you like. All right, just keep what it is if that is some kind of conclusion from that discussion.
20	16

21 } // namespace content	17 } // namespace content

22	18

23 #endif // CONTENT_RENDERER_WEBRTC_LOGGING_INITIALIZER_H_	19 #endif // CONTENT_RENDERER_WEBRTC_LOGGING_INITIALIZER_H_

OLD	NEW