Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: media/filters/ffmpeg_demuxer.cc

Issue 23691042: Fixes a duplication and bad name choice for logging media information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer.cc
diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc
index 30cb0c0029857c8f19cf0b0d33dc75c143635163..07bb77b9b42949b19a4a778e1f33dde3396bc4ca 100644
--- a/media/filters/ffmpeg_demuxer.cc
+++ b/media/filters/ffmpeg_demuxer.cc
@@ -595,8 +595,6 @@ void FFmpegDemuxer::OnFindStreamInfoDone(const PipelineStatusCB& status_cb,
media_log_->SetStringProperty("audio_codec_name", codec->name);
}
- media_log_->SetIntegerProperty("audio_sample_rate",
- audio_codec->sample_rate);
Ty Overby 2013/09/05 22:10:57 audio_codec->sample_rate gives you the same inform
media_log_->SetIntegerProperty("audio_channels_count",
audio_codec->channels);
media_log_->SetIntegerProperty("audio_samples_per_second",
@@ -637,7 +635,7 @@ void FFmpegDemuxer::OnFindStreamInfoDone(const PipelineStatusCB& status_cb,
media_log_->SetDoubleProperty("max_duration", max_duration.InSecondsF());
media_log_->SetDoubleProperty("start_time", start_time_.InSecondsF());
- media_log_->SetDoubleProperty("filesize_in_bytes",
+ media_log_->SetDoubleProperty("total_bytes",
Ty Overby 2013/09/05 22:10:57 "total_bytes" is used by the network infrastructur
scherkus (not reviewing) 2013/09/06 20:47:57 I would remove logging this if the it's already ha
Ty Overby 2013/09/09 17:29:04 Sometimes the networking layer doesn't report it,
scherkus (not reviewing) 2013/09/09 17:56:50 ah I thought by network infrastructure you were re
static_cast<double>(filesize_in_bytes));
media_log_->SetIntegerProperty("bitrate", bitrate_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698