Fixes a duplication and bad name choice for logging media information.

Fixes a duplication and bad name choice for logging media information.

BUG=260005
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222088

[Ty Overby, 2013-09-05 22:10:57]

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer.cc
File media/filters/ffmpeg_demuxer.cc (left):

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer....
media/filters/ffmpeg_demuxer.cc:599: audio_codec->sample_rate);
audio_codec->sample_rate gives you the same information as
audio_config.samples_per_second() which we already log.  

My reason for choosing to use audio_config is that audio_config is  maintained
by chrome audio while audio_codec is from ffmpeg.

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer.cc
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer....
media/filters/ffmpeg_demuxer.cc:638:
media_log_->SetDoubleProperty("total_bytes",
"total_bytes" is used by the network infrastructure, so this will match with the
name provided by the network.

[scherkus (not reviewing), 2013-09-06 20:47:57]

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer.cc
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer....
media/filters/ffmpeg_demuxer.cc:638:
media_log_->SetDoubleProperty("total_bytes",
I would remove logging this if the it's already handled by the networking layer
instead of having to match the key name

[Ty Overby, 2013-09-09 17:29:03]

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer.cc
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer....
media/filters/ffmpeg_demuxer.cc:638:
media_log_->SetDoubleProperty("total_bytes",
On 2013/09/06 20:47:57, scherkus wrote:
> I would remove logging this if the it's already handled by the networking
layer
> instead of having to match the key name

Sometimes the networking layer doesn't report it, (I think this happens when
there is a cache?).

[scherkus (not reviewing), 2013-09-09 17:56:49]

lgtm

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer.cc
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/23691042/diff/1/media/filters/ffmpeg_demuxer....
media/filters/ffmpeg_demuxer.cc:638:
media_log_->SetDoubleProperty("total_bytes",
On 2013/09/09 17:29:04, Ty Overby wrote:
> On 2013/09/06 20:47:57, scherkus wrote:
> > I would remove logging this if the it's already handled by the networking
> layer
> > instead of having to match the key name
> 
> Sometimes the networking layer doesn't report it, (I think this happens when
> there is a cache?).

ah I thought by network infrastructure you were referring to
Buffered{DataSource,ResourceLoader}, which is where filesize_in_bytes comes from
but it looks like we don't have much logging there yet

disregard my comment then

[commit-bot: I haz the power, 2013-09-09 18:00:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoverby@chromium.org/23691042/1

[commit-bot: I haz the power, 2013-09-09 20:56:31]

Change committed as 222088