chrome/common/extensions/features/base_feature_provider_unittest.cc - Issue 23691012: Renamed packaged_app to legacy_packaged_app in extension feature files. It's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/base_feature_provider_unittest.cc

Issue 23691012: Renamed packaged_app to legacy_packaged_app in extension feature files. It's (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tostring message Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/_permission_features.json ('k') | chrome/common/extensions/features/complex_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/base_feature_provider_unittest.cc

diff --git a/chrome/common/extensions/features/base_feature_provider_unittest.cc b/chrome/common/extensions/features/base_feature_provider_unittest.cc

index 30f6abb358cf2dc02defb1bb916e03dbc8152764..d31d3deb8f8d5889b05a9e29bf6dffc28fd7c520 100644

--- a/chrome/common/extensions/features/base_feature_provider_unittest.cc

+++ b/chrome/common/extensions/features/base_feature_provider_unittest.cc

@@ -146,15 +146,15 @@ TEST(BaseFeatureProviderTest, Validation) {

TEST(BaseFeatureProviderTest, ComplexFeatures) {

scoped_ptr<base::DictionaryValue> rule(

DictionaryBuilder()

- .Set("feature1",

- ListBuilder().Append(DictionaryBuilder()

- .Set("channel", "beta")

- .Set("extension_types",

- ListBuilder().Append("extension")))

- .Append(DictionaryBuilder()

- .Set("channel", "beta")

- .Set("extension_types",

- ListBuilder().Append("packaged_app"))))

+ .Set("feature1", ListBuilder()

+ .Append(DictionaryBuilder()

+ .Set("channel", "beta")

+ .Set("extension_types", ListBuilder()

+ .Append("extension")))

+ .Append(DictionaryBuilder()

+ .Set("channel", "beta")

+ .Set("extension_types", ListBuilder()

+ .Append("legacy_packaged_app"))))

.Build());

scoped_ptr<BaseFeatureProvider> provider(