Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 23688008: [NaCl Docs] Add some messaging system docs for how to use pp::VarDictionaries. (Closed)

Created:
7 years, 2 months ago by jvoung (off chromium)
Modified:
7 years, 2 months ago
Reviewers:
eliben, Sam Clegg, binji
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

[NaCl Docs] Add some messaging system docs for how to use pp::VarDictionaries. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225100

Patch Set 1 #

Total comments: 4

Patch Set 2 : add JS version of send #

Patch Set 3 : spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M native_client_sdk/src/doc/devguide/coding/message-system.rst View 1 2 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvoung (off chromium)
worth adding?
7 years, 2 months ago (2013-09-24 18:46:05 UTC) #1
eliben
lgtm
7 years, 2 months ago (2013-09-24 21:08:31 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-09-24 21:48:10 UTC) #3
binji
a few comments, otherwise lgtm https://chromiumcodereview.appspot.com/23688008/diff/1/native_client_sdk/src/doc/devguide/coding/message-system.rst File native_client_sdk/src/doc/devguide/coding/message-system.rst (right): https://chromiumcodereview.appspot.com/23688008/diff/1/native_client_sdk/src/doc/devguide/coding/message-system.rst#newcode367 native_client_sdk/src/doc/devguide/coding/message-system.rst:367: objects. For example, messages ...
7 years, 2 months ago (2013-09-24 21:56:25 UTC) #4
jvoung (off chromium)
https://chromiumcodereview.appspot.com/23688008/diff/1/native_client_sdk/src/doc/devguide/coding/message-system.rst File native_client_sdk/src/doc/devguide/coding/message-system.rst (right): https://chromiumcodereview.appspot.com/23688008/diff/1/native_client_sdk/src/doc/devguide/coding/message-system.rst#newcode367 native_client_sdk/src/doc/devguide/coding/message-system.rst:367: objects. For example, messages can be JavaScript dictionaries. On ...
7 years, 2 months ago (2013-09-24 22:35:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/23688008/10001
7 years, 2 months ago (2013-09-24 23:16:32 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-24 23:22:24 UTC) #7
Message was sent while issue was closed.
Change committed as 225100

Powered by Google App Engine
This is Rietveld 408576698