Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/renderer/renderer_main_platform_delegate_win.cc

Issue 23687007: Remove redundant exit-detection code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_main_platform_delegate_win.cc
diff --git a/content/renderer/renderer_main_platform_delegate_win.cc b/content/renderer/renderer_main_platform_delegate_win.cc
index 44d5166f6ffbb5584cd77b7ae3171cc82d1a8b3f..c4b46163cbc6692d99da069a3c12a7db67aea334 100644
--- a/content/renderer/renderer_main_platform_delegate_win.cc
+++ b/content/renderer/renderer_main_platform_delegate_win.cc
@@ -43,14 +43,6 @@ void SkiaPreCacheFontCharacters(const LOGFONT& logfont,
}
}
-void InitExitInterceptions() {
- // If code subsequently tries to exit using exit(), _exit(), abort(), or
- // ExitProcess(), force a crash (since otherwise these would be silent
- // terminations and fly under the radar).
- base::win::SetShouldCrashOnProcessDetach(true);
- base::win::SetAbortBehaviorForCrashReporting();
-}
-
#if !defined(NDEBUG)
LRESULT CALLBACK WindowsHookCBT(int code, WPARAM w_param, LPARAM l_param) {
CHECK_NE(code, HCBT_CREATEWND)
@@ -59,7 +51,6 @@ LRESULT CALLBACK WindowsHookCBT(int code, WPARAM w_param, LPARAM l_param) {
}
#endif // !NDEBUG
-
} // namespace
RendererMainPlatformDelegate::RendererMainPlatformDelegate(
@@ -81,8 +72,6 @@ void RendererMainPlatformDelegate::PlatformInitialize() {
SetWindowsHookEx(WH_CBT, WindowsHookCBT, NULL, ::GetCurrentThreadId()));
#endif // !NDEBUG
- InitExitInterceptions();
-
const CommandLine& command_line = parameters_.command_line;
#ifdef ENABLE_VTUNE_JIT_INTERFACE
@@ -109,9 +98,6 @@ void RendererMainPlatformDelegate::PlatformInitialize() {
}
void RendererMainPlatformDelegate::PlatformUninitialize() {
- // At this point we are shutting down in a normal code path, so undo our
- // hack to crash on exit.
- base::win::SetShouldCrashOnProcessDetach(false);
}
bool RendererMainPlatformDelegate::InitSandboxTests(bool no_sandbox) {
« no previous file with comments | « content/ppapi_plugin/ppapi_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698