Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 23687007: Remove redundant exit-detection code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/renderer_main_platform_delegate_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/ppapi_plugin/ppapi_thread.cc
diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc
index c2b4e04c9550e1c240862df18dc7d6be7d8aef44..c4021cb7ea0a3a49323f29e417a47f66cdd31181 100644
--- a/content/ppapi_plugin/ppapi_thread.cc
+++ b/content/ppapi_plugin/ppapi_thread.cc
@@ -115,11 +115,6 @@ void PpapiThread::Shutdown() {
if (plugin_entry_points_.shutdown_module)
plugin_entry_points_.shutdown_module();
WebKit::shutdown();
-
-#if defined(OS_WIN)
- if (permissions_.HasPermission(ppapi::PERMISSION_FLASH))
- base::win::SetShouldCrashOnProcessDetach(false);
-#endif
}
bool PpapiThread::Send(IPC::Message* msg) {
@@ -308,11 +303,6 @@ void PpapiThread::OnLoadPlugin(const base::FilePath& path,
// If code subsequently tries to exit using abort(), force a crash (since
// otherwise these would be silent terminations and fly under the radar).
base::win::SetAbortBehaviorForCrashReporting();
- if (permissions.HasPermission(ppapi::PERMISSION_FLASH)) {
- // Force a crash for exit(), _exit(), or ExitProcess(), but only do that for
- // Pepper Flash.
- base::win::SetShouldCrashOnProcessDetach(true);
- }
// Once we lower the token the sandbox is locked down and no new modules
// can be loaded. TODO(cpu): consider changing to the loading style of
« no previous file with comments | « no previous file | content/renderer/renderer_main_platform_delegate_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698