Issue 23685005: Clarify the specification of WriteFrames()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23685005: Clarify the specification of WriteFrames() (Closed)

Created:
7 years, 3 months ago by Adam Rice

Modified:
7 years, 3 months ago

Reviewers:
tyoshino (SeeGerritForStatus), yhirano

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

WriteFrames() only handles complete frames. Clarify that point. TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221401

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	net/websockets/websocket_stream.h	View		2 chunks	+15 lines, -12 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/23685005/1

7 years, 3 months ago (2013-09-05 03:51:07 UTC) #5

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83008

7 years, 3 months ago (2013-09-05 04:27:43 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/23685005/1

7 years, 3 months ago (2013-09-05 09:10:15 UTC) #7

Message was sent while issue was closed.

Change committed as 221401

Expand Messages | Collapse Messages