Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5386)

Unified Diff: chrome/browser/ui/sad_tab_helper.h

Issue 23684030: Remove notifications from the sad tab helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sad_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sad_tab_helper.h
diff --git a/chrome/browser/ui/sad_tab_helper.h b/chrome/browser/ui/sad_tab_helper.h
index 0ea35d0fb73a4ff424c9377b3d32b2129919ebca..f61da72e28b0b660c4758e0f8708596591534d0c 100644
--- a/chrome/browser/ui/sad_tab_helper.h
+++ b/chrome/browser/ui/sad_tab_helper.h
@@ -8,8 +8,6 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -19,7 +17,6 @@ class SadTab;
// Per-tab class to manage sad tab views.
class SadTabHelper : public content::WebContentsObserver,
- public content::NotificationObserver,
public content::WebContentsUserData<SadTabHelper> {
public:
virtual ~SadTabHelper();
@@ -34,16 +31,9 @@ class SadTabHelper : public content::WebContentsObserver,
void InstallSadTab(base::TerminationStatus status);
// Overridden from content::WebContentsObserver:
+ virtual void RenderViewReady() OVERRIDE;
virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;
- // Overridden from content::NotificationObserver:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
- // Used to get notifications about renderers coming and going.
- content::NotificationRegistrar registrar_;
-
scoped_ptr<chrome::SadTab> sad_tab_;
DISALLOW_COPY_AND_ASSIGN(SadTabHelper);
« no previous file with comments | « no previous file | chrome/browser/ui/sad_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698