Fix warning in Xcode about only building the active arch in Debug.

Fix warning in Xcode about only building the active arch in Debug.

In Xcode, each project has a warning that "Build only for active 
architecture" should be enabled for Debug configuration. This change to 
common.gypi sets the ONLY_ACTIVE_ARCH variable at the project level for 
Debug configurations.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220960

[Mark Mentovai, 2013-09-03 13:52:22]

https://codereview.chromium.org/23684011/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23684011/diff/1/build/common.gypi#newcode4651
build/common.gypi:4651: # avoids a project-level warning in Xcode.
So this needs to be a project-level setting.

Right under 'configurations' above, you should approximately duplicate the same
warning from 'xcode_settings' immediately below, then.

[lliabraa, 2013-09-03 14:07:35]

Thanks for the review.

https://codereview.chromium.org/23684011/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23684011/diff/1/build/common.gypi#newcode4651
build/common.gypi:4651: # avoids a project-level warning in Xcode.
On 2013/09/03 13:52:22, Mark Mentovai wrote:
> So this needs to be a project-level setting.
> 
> Right under 'configurations' above, you should approximately duplicate the
same
> warning from 'xcode_settings' immediately below, then.

Done.

[Mark Mentovai, 2013-09-03 14:09:08]

LGTM otherwise

https://codereview.chromium.org/23684011/diff/6001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23684011/diff/6001/build/common.gypi#newcode4651
build/common.gypi:4651: # custom xcode_settings in target_defaults to add them
to targets instead.
Not xcode_settings.

[stuartmorgan, 2013-09-03 14:11:22]

lgtm

[lliabraa, 2013-09-03 14:30:54]

https://codereview.chromium.org/23684011/diff/6001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23684011/diff/6001/build/common.gypi#newcode4651
build/common.gypi:4651: # custom xcode_settings in target_defaults to add them
to targets instead.
On 2013/09/03 14:09:08, Mark Mentovai wrote:
> Not xcode_settings.

d'oh. Fixed.

[commit-bot: I haz the power, 2013-09-03 14:31:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/23684011/12001

[commit-bot: I haz the power, 2013-09-03 17:03:15]

Change committed as 220960

[rohitrao (ping after 24h), 2013-09-06 12:54:38]

After this change, I am unable to build a Debug device binary for my iPhone5:

No architectures to compile for (ONLY_ACTIVE_ARCH=YES, active arch=armv7s,
VALID_ARCHS=armv7 i386).

[rohitrao (ping after 24h), 2013-09-06 13:33:31]

On 2013/09/06 12:54:38, rohitrao wrote:
> After this change, I am unable to build a Debug device binary for my iPhone5:
> 
> No architectures to compile for (ONLY_ACTIVE_ARCH=YES, active arch=armv7s,
> VALID_ARCHS=armv7 i386).

How about expanding the VALID_ARCHS list to include armv7s for Debug only?  That
would solve my problem, at the expense of compiling to a different binary
depending on which phone is plugged in.  On the other hand, we're compiling in
Debug mode anyways, so does it matter that much?

If we make this a Debug-only change, then Release builds wouldn't be affected,
and we would continue shipping armv7-only binaries.