Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 23684008: Fix bounds computation in GrAAHairlineRenderer (Closed)

Created:
7 years, 3 months ago by bsalomon
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix bounds computation in GrAAHairlineRenderer Committed: http://code.google.com/p/skia/source/detail?r=11054

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rob's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -16 lines) Patch
M gm/hairlines.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M include/core/SkRect.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 8 chunks +31 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 3 months ago (2013-08-31 18:40:32 UTC) #1
robertphillips
lgtm + 2 questions https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h File include/core/SkRect.h (right): https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h#newcode695 include/core/SkRect.h:695: void growToInclude(const SkPoint pts[], int ...
7 years, 3 months ago (2013-09-01 11:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23684008/7001
7 years, 3 months ago (2013-09-03 14:47:28 UTC) #3
bsalomon
https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h File include/core/SkRect.h (right): https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h#newcode695 include/core/SkRect.h:695: void growToInclude(const SkPoint pts[], int count) { On 2013/09/01 ...
7 years, 3 months ago (2013-09-03 14:47:35 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 14:56:21 UTC) #5
Message was sent while issue was closed.
Change committed as 11054

Powered by Google App Engine
This is Rietveld 408576698