Fix bounds computation in GrAAHairlineRenderer

Fix bounds computation in GrAAHairlineRenderer

Committed: http://code.google.com/p/skia/source/detail?r=11054

[robertphillips, 2013-09-01 11:15:37]

lgtm + 2 questions

https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h
File include/core/SkRect.h (right):

https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h#newcode695
include/core/SkRect.h:695: void growToInclude(const SkPoint pts[], int count) {
Shouldn't this be (pts, sizeof(SkPoint), count)?

https://codereview.chromium.org/23684008/diff/1/src/gpu/GrAAHairLinePathRende...
File src/gpu/GrAAHairLinePathRenderer.cpp (right):

https://codereview.chromium.org/23684008/diff/1/src/gpu/GrAAHairLinePathRende...
src/gpu/GrAAHairLinePathRenderer.cpp:845: } else {
Why is it true that if it doesn't have perspective it is the identity?

[commit-bot: I haz the power, 2013-09-03 14:47:28]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23684008/7001

[bsalomon, 2013-09-03 14:47:35]

https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h
File include/core/SkRect.h (right):

https://codereview.chromium.org/23684008/diff/1/include/core/SkRect.h#newcode695
include/core/SkRect.h:695: void growToInclude(const SkPoint pts[], int count) {
On 2013/09/01 11:15:37, robertphillips wrote:
> Shouldn't this be (pts, sizeof(SkPoint), count)?


Yes nice catch. I originally had it as ptr, stride, count but changed it to be
consistent with the strided methods on SkMatrix (and forgot to update this
caller).

https://codereview.chromium.org/23684008/diff/1/src/gpu/GrAAHairLinePathRende...
File src/gpu/GrAAHairLinePathRenderer.cpp (right):

https://codereview.chromium.org/23684008/diff/1/src/gpu/GrAAHairLinePathRende...
src/gpu/GrAAHairLinePathRenderer.cpp:845: } else {
On 2013/09/01 11:15:37, robertphillips wrote:
> Why is it true that if it doesn't have perspective it is the identity?

This path renderer renders in device space for non-persp matrices. Added
comment.

[commit-bot: I haz the power, 2013-09-03 14:56:21]

Change committed as 11054