Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 23684002: Introduce WebSocketHandle and WebSocketHandleClient. (Closed)

Created:
7 years, 3 months ago by yhirano
Modified:
7 years, 3 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce WebSocketHandle and WebSocketHandleClient. Introduce WebSocketHandle and WebSocketHandleClient in public/platform. They are interface classes for the new WebSocket implementation. This CL does not change any behavior. BUG=275459 R=tyoshino, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -46 lines) Patch
M public/platform/Platform.h View 2 chunks +4 lines, -0 lines 0 comments Download
A + public/platform/WebSocketHandle.h View 1 chunk +21 lines, -28 lines 0 comments Download
A + public/platform/WebSocketHandleClient.h View 2 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yhirano
7 years, 3 months ago (2013-08-28 07:38:01 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-08-28 07:45:43 UTC) #2
abarth-chromium
Thanks for breaking down the CL.
7 years, 3 months ago (2013-08-28 07:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/23684002/1
7 years, 3 months ago (2013-08-28 07:47:38 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm you may want to remove WebData later.
7 years, 3 months ago (2013-08-28 07:51:35 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 09:20:36 UTC) #6
Message was sent while issue was closed.
Change committed as 156834

Powered by Google App Engine
This is Rietveld 408576698