Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2368393003: [inspector] added inspector test runner [part 2] (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added inspector test runner [part 2] - added the channel implementation, - added inspector implementation, - added v8::Extension for communication between backend and frontend. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/cceaa1225c6a96a28d2c7410d1db520423fb8c31 Committed: https://crrev.com/751814a1282396aef80b48f7f41ea38eab5e1456 Cr-Original-Commit-Position: refs/heads/master@{#39888} Cr-Commit-Position: refs/heads/master@{#39928}

Patch Set 1 #

Patch Set 2 : convert utf16 into utf8 in SendMessageToFrontend #

Patch Set 3 : added missing handle scope #

Patch Set 4 : added missing microtask scope #

Total comments: 12

Patch Set 5 : addressed comments #

Total comments: 4

Patch Set 6 : addressed comments #

Patch Set 7 : move more InspectorClientImpl functions to private #

Total comments: 4

Patch Set 8 : std::string > String16 #

Patch Set 9 : StringView -> String16 in SendMessageToBackendTask cstor #

Patch Set 10 : rebased #

Patch Set 11 : rebased #

Patch Set 12 : fixed linter errors #

Total comments: 6

Patch Set 13 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -0 lines) Patch
M test/inspector/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M test/inspector/inspector.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
A test/inspector/inspector-impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +76 lines, -0 lines 0 comments Download
A test/inspector/inspector-impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (20 generated)
kozy
Dmitry, please take a look.
4 years, 2 months ago (2016-09-26 19:16:34 UTC) #1
dgozman
https://codereview.chromium.org/2368393003/diff/60001/test/inspector-protocol/inspector-impl.cc File test/inspector-protocol/inspector-impl.cc (right): https://codereview.chromium.org/2368393003/diff/60001/test/inspector-protocol/inspector-impl.cc#newcode114 test/inspector-protocol/inspector-impl.cc:114: void BackendExtension::EvaluateInFrontend( Let's remove this. https://codereview.chromium.org/2368393003/diff/60001/test/inspector-protocol/inspector-impl.cc#newcode143 test/inspector-protocol/inspector-impl.cc:143: v8::MicrotasksScope microtasks_scope(isolate, ...
4 years, 2 months ago (2016-09-27 16:30:36 UTC) #2
kozy
All done. Please take a look! https://codereview.chromium.org/2368393003/diff/60001/test/inspector-protocol/inspector-impl.cc File test/inspector-protocol/inspector-impl.cc (right): https://codereview.chromium.org/2368393003/diff/60001/test/inspector-protocol/inspector-impl.cc#newcode114 test/inspector-protocol/inspector-impl.cc:114: void BackendExtension::EvaluateInFrontend( On ...
4 years, 2 months ago (2016-09-27 17:00:53 UTC) #4
dgozman
https://codereview.chromium.org/2368393003/diff/100001/test/inspector-protocol/DEPS File test/inspector-protocol/DEPS (right): https://codereview.chromium.org/2368393003/diff/100001/test/inspector-protocol/DEPS#newcode7 test/inspector-protocol/DEPS:7: "+src/vector.h", Unused? https://codereview.chromium.org/2368393003/diff/100001/test/inspector-protocol/inspector-impl.h File test/inspector-protocol/inspector-impl.h (right): https://codereview.chromium.org/2368393003/diff/100001/test/inspector-protocol/inspector-impl.h#newcode66 test/inspector-protocol/inspector-impl.h:66: class ...
4 years, 2 months ago (2016-09-27 18:41:20 UTC) #5
kozy
All done. Please take another look! https://codereview.chromium.org/2368393003/diff/100001/test/inspector-protocol/DEPS File test/inspector-protocol/DEPS (right): https://codereview.chromium.org/2368393003/diff/100001/test/inspector-protocol/DEPS#newcode7 test/inspector-protocol/DEPS:7: "+src/vector.h", On 2016/09/27 ...
4 years, 2 months ago (2016-09-27 19:31:22 UTC) #6
dgozman
lgtm https://codereview.chromium.org/2368393003/diff/140001/test/inspector-protocol/inspector-impl.cc File test/inspector-protocol/inspector-impl.cc (right): https://codereview.chromium.org/2368393003/diff/140001/test/inspector-protocol/inspector-impl.cc#newcode128 test/inspector-protocol/inspector-impl.cc:128: std::string message_; String16? https://codereview.chromium.org/2368393003/diff/140001/test/inspector-protocol/inspector-impl.h File test/inspector-protocol/inspector-impl.h (right): https://codereview.chromium.org/2368393003/diff/140001/test/inspector-protocol/inspector-impl.h#newcode56 ...
4 years, 2 months ago (2016-09-28 16:10:58 UTC) #9
kozy
All done. https://codereview.chromium.org/2368393003/diff/140001/test/inspector-protocol/inspector-impl.cc File test/inspector-protocol/inspector-impl.cc (right): https://codereview.chromium.org/2368393003/diff/140001/test/inspector-protocol/inspector-impl.cc#newcode128 test/inspector-protocol/inspector-impl.cc:128: std::string message_; On 2016/09/28 16:10:57, dgozman wrote: ...
4 years, 2 months ago (2016-09-28 17:03:03 UTC) #10
kozy
Alexey, please take a look!
4 years, 2 months ago (2016-09-29 14:31:44 UTC) #15
alph
lgtm w/ nits https://codereview.chromium.org/2368393003/diff/240001/test/inspector/inspector-impl.h File test/inspector/inspector-impl.h (right): https://codereview.chromium.org/2368393003/diff/240001/test/inspector/inspector-impl.h#newcode18 test/inspector/inspector-impl.h:18: virtual ~FrontendChannel() {} = default; https://codereview.chromium.org/2368393003/diff/240001/test/inspector/inspector-impl.h#newcode30 ...
4 years, 2 months ago (2016-09-29 20:05:53 UTC) #18
kozy
All done. thanks! https://codereview.chromium.org/2368393003/diff/240001/test/inspector/inspector-impl.h File test/inspector/inspector-impl.h (right): https://codereview.chromium.org/2368393003/diff/240001/test/inspector/inspector-impl.h#newcode18 test/inspector/inspector-impl.h:18: virtual ~FrontendChannel() {} On 2016/09/29 20:05:52, ...
4 years, 2 months ago (2016-09-29 20:59:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368393003/280001
4 years, 2 months ago (2016-09-29 21:02:44 UTC) #23
commit-bot: I haz the power
Committed patchset #13 (id:280001)
4 years, 2 months ago (2016-09-29 21:40:32 UTC) #25
commit-bot: I haz the power
Patchset 13 (id:??) landed as https://crrev.com/cceaa1225c6a96a28d2c7410d1db520423fb8c31 Cr-Commit-Position: refs/heads/master@{#39888}
4 years, 2 months ago (2016-09-29 21:40:59 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368393003/280001
4 years, 2 months ago (2016-10-02 16:12:48 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368393003/280001
4 years, 2 months ago (2016-10-02 16:13:47 UTC) #33
commit-bot: I haz the power
Committed patchset #13 (id:280001)
4 years, 2 months ago (2016-10-02 16:45:42 UTC) #35
commit-bot: I haz the power
4 years, 2 months ago (2016-10-02 16:45:51 UTC) #37
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/751814a1282396aef80b48f7f41ea38eab5e1456
Cr-Commit-Position: refs/heads/master@{#39928}

Powered by Google App Engine
This is Rietveld 408576698