Issue 23682003: Fix comment for WebUIDataSource::DisableReplaceExistingSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23682003: Fix comment for WebUIDataSource::DisableReplaceExistingSource (Closed)

Created:
7 years, 3 months ago by shuais_

Modified:
7 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix comment for WebUIDataSource::DisableReplaceExistingSource Follow-up of review 22150004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220297

Patch Set 2 : Period #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	content/public/browser/web_ui_data_source.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/23682003/diff/1/content/public/browser/web_ui_data_source.h File content/public/browser/web_ui_data_source.h (right): https://codereview.chromium.org/23682003/diff/1/content/public/browser/web_ui_data_source.h#newcode82 content/public/browser/web_ui_data_source.h:82: // Currently only used by embedders for WebUIs ...

7 years, 3 months ago (2013-08-28 15:50:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuais@opera.com/23682003/6001

7 years, 3 months ago (2013-08-29 07:09:03 UTC) #3

Message was sent while issue was closed.

Change committed as 220297

Expand Messages | Collapse Messages

Issue 23682003: Fix comment for WebUIDataSource::DisableReplaceExistingSource (Closed)

Description

Patch Set 1 #

Patch Set 2 : Period #

Messages