Android: splits cache_control and perf_control.

Android: splits cache_control and perf_control.

Second step towards deprecating "perf_tests_helper.py"
towards more meaningful modules.
Also move thermal_throttle.py into perf/ and some
other minor cleanup.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223606

[bulach, 2013-09-16 10:25:41]

ptal

frank, FYI rschoen@ started the clean up here:
https://chromiumcodereview.appspot.com/23578019/

downstream change coming up in a bit, then once both lands, I'll do another pass
to get rid of build/android/pylib/perf_tests_helper.py altogether, so we'll only
have:
build/android/pylib/cache_control.py
build/android/pylib/perf_control.py
and
build/util/lib/common/perf_tests_results_helper.py

[frankf, 2013-09-16 18:09:22]

lgtm w/ nits

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
File build/android/pylib/cache_control.py (right):

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
build/android/pylib/cache_control.py:1: # Copyright (c) 2013 The Chromium
Authors. All rights reserved.
Can we move all perf-specific modules to perf/ dir?

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
build/android/pylib/cache_control.py:16: self._adb.RunShellCommand('su -c sync')
Can we add a RunShellCommandAsRoot('sync')?
It helps SEO :)

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/perf_cont...
File build/android/pylib/perf_control.py (right):

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/perf_cont...
build/android/pylib/perf_control.py:20: assert kernel_max, 'Unable to find
/sys/devices/system/cpu/kernel_max'
DRY: Factor out the path

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/perf_cont...
build/android/pylib/perf_control.py:22: logging.info('Maximum CPU index: %d' %
self._kernel_max)
run gpylint: You can pass self._kernel_max as additional param

[dtu, 2013-09-16 18:36:59]

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
File build/android/pylib/cache_control.py (right):

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
build/android/pylib/cache_control.py:1: # Copyright (c) 2013 The Chromium
Authors. All rights reserved.
On 2013/09/16 18:09:23, frankf wrote:
> Can we move all perf-specific modules to perf/ dir?

Feel free to put them in telemetry/core/platform/android or wherever else you
think fits.

[bulach, 2013-09-16 19:51:09]

thanks! all comments addressed, ptal.

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
File build/android/pylib/cache_control.py (right):

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
build/android/pylib/cache_control.py:1: # Copyright (c) 2013 The Chromium
Authors. All rights reserved.
On 2013/09/16 18:36:59, dtu wrote:
> On 2013/09/16 18:09:23, frankf wrote:
> > Can we move all perf-specific modules to perf/ dir?
> 
> Feel free to put them in telemetry/core/platform/android or wherever else you
> think fits.

good point, moved to build/android/pylib/perf

reason being that downstream has some dependencies to it and already depend on
pylib, so I wouldn't want to make them dependent on telemetry..

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/cache_con...
build/android/pylib/cache_control.py:16: self._adb.RunShellCommand('su -c sync')
On 2013/09/16 18:09:23, frankf wrote:
> Can we add a RunShellCommandAsRoot('sync')?
> It helps SEO :)

Done.

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/perf_cont...
File build/android/pylib/perf_control.py (right):

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/perf_cont...
build/android/pylib/perf_control.py:20: assert kernel_max, 'Unable to find
/sys/devices/system/cpu/kernel_max'
On 2013/09/16 18:09:23, frankf wrote:
> DRY: Factor out the path

Done.

https://codereview.chromium.org/23681011/diff/1/build/android/pylib/perf_cont...
build/android/pylib/perf_control.py:22: logging.info('Maximum CPU index: %d' %
self._kernel_max)
On 2013/09/16 18:09:23, frankf wrote:
> run gpylint: You can pass self._kernel_max as additional param

Done.

[frankf, 2013-09-16 19:58:09]

still lgtm. There are other perf modules, feel free to move in another CL
though:

- surface_stats_collector.py
- io_stats_parser.py
- json_perf_parser.py

[RyanS, 2013-09-16 19:59:06]

lgtm. Thanks Marcus!

[bulach, 2013-09-17 08:39:56]

thanks everyone!

frank, I partially followed your suggestion :)
- surface_stats_collector.py --> perf/
- io_stats_parser.py --> did not move. it's only used by android_commands.py and
device_stats_monitor.py, so I'm not sure it's actually perf/
- json_perf_parser.py --> instrumentation/.. this is used by the "ui automation
perf" downstream and only used within instrumentation, so I thought that would
be a better place..

happy to follow up on any of this, but landing as is so we can start the other
cleanup within telemetry and unblock rschoen.

[commit-bot: I haz the power, 2013-09-17 09:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/23681011/16001

[commit-bot: I haz the power, 2013-09-17 13:52:46]

Change committed as 223606