Issue 23681010: Prevent that uninitialized ManagedState objects are returned from NetworkStateHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23681010: Prevent that uninitialized ManagedState objects are returned from NetworkStateHandler. (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)

Modified:
7 years, 3 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Prevent that uninitialized ManagedState objects are returned from NetworkStateHandler. This CL https://codereview.chromium.org/23712002 (Cleanup network type matching.) uncovered, that some NetworkStateHandler functions returned NetworkState objects that were not fully initialized, namely type() was empty. BUG=126870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222035

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -16 lines)			Patch
	M	chromeos/network/network_state_handler.cc	View		13 chunks	+29 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23681010/11001

7 years, 3 months ago (2013-09-09 09:52:31 UTC) #3

Message was sent while issue was closed.

Change committed as 222035