Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 23680013: Add const versions of some toHTMLFooElement(). (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Add const versions of some toHTMLFooElement(). We'd like to avoid bare static_cast<const Foo*> too. BUG=none TEST=none; no behavior change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M Source/core/dom/Node.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMetaElement.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
7 years, 3 months ago (2013-09-09 06:06:44 UTC) #1
esprehn
LGTM, we really need to switch to auto generating all these methods like they do ...
7 years, 3 months ago (2013-09-09 06:24:49 UTC) #2
tkent
On 2013/09/09 06:24:49, esprehn wrote: > LGTM, we really need to switch to auto generating ...
7 years, 3 months ago (2013-09-09 06:27:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23680013/1
7 years, 3 months ago (2013-09-09 06:27:47 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 06:34:11 UTC) #5
Message was sent while issue was closed.
Change committed as 157440

Powered by Google App Engine
This is Rietveld 408576698