Issue 23680003: Delete IBusPanelService from DBusThreadManager

Issue 23680003: Delete IBusPanelService from DBusThreadManager (Closed)

Created:
7 years, 3 months ago by Hiro Komatsu

Modified:
7 years, 3 months ago

Reviewers:
satorux1, Seigo Nonaka

CC:
chromium-reviews, yusukes+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Delete IBusPanelService from DBusThreadManager Remove chromeos/dbus dependency from CandidateWindowController. BUG=280438 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220548

Patch Set 1 #

Patch Set 2 : Changed the codebase. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -27 lines)			Patch
M	chromeos/dbus/dbus_thread_manager.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	4 chunks	+0 lines, -10 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.h	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Hiro Komatsu

After this CL, I will delete chromeos/dbus/ibus/ibus_panel_service.(cc|h)

7 years, 3 months ago (2013-08-28 06:51:18 UTC) #1

Seigo Nonaka

On 2013/08/28 06:51:18, komatsu wrote: > After this CL, I will delete chromeos/dbus/ibus/ibus_panel_service.(cc|h) Why not ...

7 years, 3 months ago (2013-08-29 01:06:44 UTC) #2

Hiro Komatsu

On 2013/08/29 01:06:44, Seigo Nonaka wrote: > On 2013/08/28 06:51:18, komatsu wrote: > > After ...

7 years, 3 months ago (2013-08-29 01:46:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23680003/2001

7 years, 3 months ago (2013-08-29 04:11:01 UTC) #5

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=22944

7 years, 3 months ago (2013-08-29 04:22:35 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23680003/2001

7 years, 3 months ago (2013-08-30 06:55:16 UTC) #9

Message was sent while issue was closed.

Change committed as 220548

Expand Messages | Collapse Messages