Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: chrome/renderer/extensions/binding_generating_native_handler.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/binding_generating_native_handler.h" 5 #include "chrome/renderer/extensions/binding_generating_native_handler.h"
6 6
7 #include "chrome/renderer/extensions/module_system.h" 7 #include "chrome/renderer/extensions/module_system.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 10
11 BindingGeneratingNativeHandler::BindingGeneratingNativeHandler( 11 BindingGeneratingNativeHandler::BindingGeneratingNativeHandler(
12 ModuleSystem* module_system, 12 ModuleSystem* module_system,
13 const std::string& api_name, 13 const std::string& api_name,
14 const std::string& bind_to) 14 const std::string& bind_to)
15 : module_system_(module_system), 15 : module_system_(module_system),
16 api_name_(api_name), 16 api_name_(api_name),
17 bind_to_(bind_to) { 17 bind_to_(bind_to) {
18 } 18 }
19 19
20 v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() { 20 v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
21 v8::HandleScope scope; 21 v8::HandleScope scope(module_system_->GetIsolate());
22 v8::Handle<v8::Object> binding_module = 22 v8::Handle<v8::Object> binding_module =
23 module_system_->Require("binding")->ToObject(); 23 module_system_->Require("binding")->ToObject();
24 v8::Handle<v8::Object> binding = 24 v8::Handle<v8::Object> binding =
25 binding_module->Get(v8::String::New("Binding"))->ToObject(); 25 binding_module->Get(v8::String::New("Binding"))->ToObject();
26 v8::Handle<v8::Function> create_binding = 26 v8::Handle<v8::Function> create_binding =
27 binding->Get(v8::String::New("create")).As<v8::Function>(); 27 binding->Get(v8::String::New("create")).As<v8::Function>();
28 v8::Handle<v8::Value> argv[] = { 28 v8::Handle<v8::Value> argv[] = {
29 v8::String::New(api_name_.c_str()) 29 v8::String::New(api_name_.c_str())
30 }; 30 };
31 v8::Handle<v8::Object> binding_instance = 31 v8::Handle<v8::Object> binding_instance =
32 create_binding->Call(binding, arraysize(argv), argv)->ToObject(); 32 create_binding->Call(binding, arraysize(argv), argv)->ToObject();
33 v8::Handle<v8::Function> generate = 33 v8::Handle<v8::Function> generate =
34 binding_instance->Get(v8::String::New("generate")).As<v8::Function>(); 34 binding_instance->Get(v8::String::New("generate")).As<v8::Function>();
35 v8::Handle<v8::Object> object = v8::Object::New(); 35 v8::Handle<v8::Object> object = v8::Object::New();
36 v8::Handle<v8::Value> compiled_schema = 36 v8::Handle<v8::Value> compiled_schema =
37 generate->Call(binding_instance, 0, NULL); 37 generate->Call(binding_instance, 0, NULL);
38 if (!compiled_schema.IsEmpty()) 38 if (!compiled_schema.IsEmpty())
39 object->Set(v8::String::New(bind_to_.c_str()), compiled_schema); 39 object->Set(v8::String::New(bind_to_.c_str()), compiled_schema);
40 return scope.Close(object); 40 return scope.Close(object);
41 } 41 }
42 42
43 } // namespace extensions 43 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698