Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/renderer/extensions/app_window_custom_bindings.cc

Issue 23679004: Remove more calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/app_window_custom_bindings.h" 5 #include "chrome/renderer/extensions/app_window_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
(...skipping 20 matching lines...) Expand all
31 content::RenderView* view, Dispatcher* dispatcher) 31 content::RenderView* view, Dispatcher* dispatcher)
32 : content::RenderViewObserver(view), dispatcher_(dispatcher) { 32 : content::RenderViewObserver(view), dispatcher_(dispatcher) {
33 } 33 }
34 34
35 virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE { 35 virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE {
36 DCHECK(frame); 36 DCHECK(frame);
37 DCHECK(dispatcher_); 37 DCHECK(dispatcher_);
38 // Don't attempt to inject the titlebar into iframes. 38 // Don't attempt to inject the titlebar into iframes.
39 if (frame->parent()) 39 if (frame->parent())
40 return; 40 return;
41 v8::HandleScope handle_scope; 41 v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
42 ChromeV8Context* v8_context = 42 ChromeV8Context* v8_context =
43 dispatcher_->v8_context_set().GetByV8Context( 43 dispatcher_->v8_context_set().GetByV8Context(
44 frame->mainWorldScriptContext()); 44 frame->mainWorldScriptContext());
45 45
46 if (!v8_context) 46 if (!v8_context)
47 return; 47 return;
48 v8::Context::Scope context_scope(v8_context->v8_context()); 48 v8::Context::Scope context_scope(v8_context->v8_context());
49 v8_context->module_system()->CallModuleMethod( 49 v8_context->module_system()->CallModuleMethod(
50 "injectAppTitlebar", "didCreateDocumentElement"); 50 "injectAppTitlebar", "didCreateDocumentElement");
51 } 51 }
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 ResourceBundle::GetSharedInstance().GetRawDataResource( 121 ResourceBundle::GetSharedInstance().GetRawDataResource(
122 IDR_WINDOW_CONTROLS_TEMPLATE_HTML).as_string()); 122 IDR_WINDOW_CONTROLS_TEMPLATE_HTML).as_string());
123 scoped_ptr<content::V8ValueConverter> converter( 123 scoped_ptr<content::V8ValueConverter> converter(
124 content::V8ValueConverter::create()); 124 content::V8ValueConverter::create());
125 result = converter->ToV8Value(value, context()->v8_context()); 125 result = converter->ToV8Value(value, context()->v8_context());
126 } 126 }
127 args.GetReturnValue().Set(result); 127 args.GetReturnValue().Set(result);
128 } 128 }
129 129
130 } // namespace extensions 130 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698