Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4429)

Unified Diff: chrome/browser/chromeos/login/merge_session_load_page.cc

Issue 23678007: OAuth2LoginManager+MergeSessionThrottle hardening, multi-profle support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/merge_session_load_page.cc
diff --git a/chrome/browser/chromeos/login/merge_session_load_page.cc b/chrome/browser/chromeos/login/merge_session_load_page.cc
index 505e69e8da536336bf33abaf9d8f9f3a9850d215..2e81c44180a92da4639a89cda7fc50680c28573f 100644
--- a/chrome/browser/chromeos/login/merge_session_load_page.cc
+++ b/chrome/browser/chromeos/login/merge_session_load_page.cc
@@ -14,6 +14,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/chromeos/login/oauth2_login_manager_factory.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
#include "chrome/browser/profiles/profile.h"
@@ -57,13 +58,15 @@ MergeSessionLoadPage::MergeSessionLoadPage(WebContents* web_contents,
proceeded_(false),
web_contents_(web_contents),
url_(url) {
- UserManager::Get()->AddObserver(this);
+ OAuth2LoginManager* manager = GetOAuth2LoginManager();
+ manager->AddObserver(this);
interstitial_page_ = InterstitialPage::Create(web_contents, true, url, this);
}
MergeSessionLoadPage::~MergeSessionLoadPage() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- UserManager::Get()->RemoveObserver(this);
+ OAuth2LoginManager* manager = GetOAuth2LoginManager();
+ manager->RemoveObserver(this);
}
void MergeSessionLoadPage::Show() {
@@ -131,16 +134,30 @@ void MergeSessionLoadPage::NotifyBlockingPageComplete() {
}
}
-void MergeSessionLoadPage::MergeSessionStateChanged(
- UserManager::MergeSessionState state) {
+OAuth2LoginManager* MergeSessionLoadPage::GetOAuth2LoginManager() {
+ content::BrowserContext* browser_context = web_contents_->GetBrowserContext();
+ if (!browser_context)
+ return NULL;
+
+ Profile* profile = Profile::FromBrowserContext(browser_context);
+ if (!profile)
+ return NULL;
+
+ return OAuth2LoginManagerFactory::GetInstance()->GetForProfile(profile);
+}
+
+void MergeSessionLoadPage::OnSessionRestoreStateChanged(
+ Profile* user_profile, OAuth2LoginManager::SessionRestoreState state) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DVLOG(1) << "Merge session is "
- << (state != UserManager:: MERGE_STATUS_IN_PROCESS ?
+
+ OAuth2LoginManager* manager = GetOAuth2LoginManager();
+ DVLOG(1) << "Merge session should "
+ << (!manager->ShouldBlockTabLoading() ?
" NOT " : "")
- << " in progress, "
+ << " be blocking now, "
<< state;
- if (state != UserManager:: MERGE_STATUS_IN_PROCESS) {
- UserManager::Get()->RemoveObserver(this);
+ if (!manager->ShouldBlockTabLoading()) {
+ manager->RemoveObserver(this);
interstitial_page_->Proceed();
}
}

Powered by Google App Engine
This is Rietveld 408576698