Issue 23676005: [Webapps] Add switch to about:flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23676005: [Webapps] Add switch to about:flags (Closed)

Created:
7 years, 3 months ago by gone

Modified:
7 years, 3 months ago

Reviewers:
Ted C, klobag.chromium, vinodkr1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Webapps] Add switch to about:flags Adds a flag to about:flags to make the "Add to Homescreen" menu item visible. Requires a downstream patch to actually put the menu item in. BUG=286156 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221770

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Ted C

lgtm w/ sign off from klobag or vinod for adding the flag to about:flags

7 years, 3 months ago (2013-09-06 17:12:45 UTC) #3

vinodkr1

On 2013/09/06 17:12:45, Ted C wrote: > lgtm w/ sign off from klobag or vinod ...

7 years, 3 months ago (2013-09-06 17:19:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/23676005/1

7 years, 3 months ago (2013-09-06 17:29:33 UTC) #5

Message was sent while issue was closed.

Change committed as 221770