Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 23674007: [CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads (Closed)

Created:
7 years, 3 months ago by Manuel Rego
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, chromiumbugtracker_adobe.com, leviw+renderwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads Patch by Javier Fernandez in WebKit. See http://trac.webkit.org/changeset/155058 When using CSS Regions is usual that the RenderTree doesn't match the DOM Tree in terms of relative position of the nodes. Besides, usually the content of a certain node is split and spread across multiple blocks, rendered in different positions. Regarding the Selection, this problem is even more important; the selection direction changes when crossing the FlowThread boundaries. This weird behavior is also present in other layouts using non-regular positioning mechanisms, like absolute, static. However, for those layouts the RenderTree preserves the order of the nodes, unlike the CSS Regions layout model. Because of how the RenderTree is generated with CSS Regions, the RenderView::setSelection algorithm is not able to repaint some of the rectangles defined during the selection process. In order to face this issue, the proposed fix determines whether it should backwards traversing the RenderTree, from the "stop" node to the RenderView node. Test: fast/regions/selecting-text-through-different-region-flows-2.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -22 lines) Patch
A + LayoutTests/fast/regions/selecting-text-through-different-region-flows-2.html View 2 chunks +7 lines, -12 lines 0 comments Download
A + LayoutTests/fast/regions/selecting-text-through-different-region-flows-2-expected.html View 1 chunk +14 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 6 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Manuel Rego
7 years, 3 months ago (2013-09-23 23:36:37 UTC) #1
Z_DONOTUSE
lgtm
7 years, 3 months ago (2013-09-23 23:41:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/23674007/1
7 years, 3 months ago (2013-09-23 23:42:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7397
7 years, 3 months ago (2013-09-24 00:00:21 UTC) #4
ojan
lgtm
7 years, 3 months ago (2013-09-24 00:27:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/23674007/1
7 years, 3 months ago (2013-09-24 00:27:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=6950
7 years, 3 months ago (2013-09-24 04:31:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/23674007/1
7 years, 3 months ago (2013-09-24 14:06:37 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 14:35:49 UTC) #9
Message was sent while issue was closed.
Change committed as 158274

Powered by Google App Engine
This is Rietveld 408576698