chrome/android/java/res/layout/search_engine_divider.xml - Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/search_engine_divider.xml

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/search_engine.xml ('K') | « chrome/android/java/res/layout/search_engine.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	Ian Wen 2016/09/27 04:42:00 I wouldn't call this file "divider". Instead, how I wouldn't call this file "divider". Instead, how about search_engine_recent_title ltian 2016/09/28 19:19:46 Done. Show quoted text On 2016/09/27 04:42:00, Ian Wen wrote: > I wouldn't call this file "divider". Instead, how about > search_engine_recent_title Done.
	7 android:layout_width="match_parent"

	8 android:layout_height="wrap_content"

	9 android:gravity="center_vertical"

	10 android:paddingBottom="16dp"

	11 android:paddingTop="16dp"

	12 android:paddingStart="12dp"

	13 android:paddingEnd="6dp">

	14

	15 <TextView

	16 android:text="@string/recently_visited"

	17 android:layout_width="match_parent"
	Ian Wen 2016/09/27 04:42:00 Indentation not correct. You should install androi Indentation not correct. You should install android plugin for your eclipse to solve this issue. ltian 2016/09/28 19:19:46 Done. Show quoted text On 2016/09/27 04:42:00, Ian Wen wrote: > Indentation not correct. You should install android plugin for your eclipse to > solve this issue. Done.
	18 android:layout_height="wrap_content"

	19 android:textColor="@color/light_active_color"

	20 android:textStyle="bold"

	21 android:textSize="15sp"

	22 android:gravity="center_vertical"/>

	23

	24 </LinearLayout>

OLD	NEW