Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 23672050: Refactor print-layout-test-times and add unit tests. (Closed)

Created:
7 years, 3 months ago by Dirk Pranke
Modified:
7 years, 3 months ago
Reviewers:
ojan
CC:
blink-reviews
Visibility:
Public.

Description

Refactor print-layout-test-times and add unit tests. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158144

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweak a bit to minimize diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -225 lines) Patch
M Tools/Scripts/print-layout-test-times View 1 chunk +32 lines, -146 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/systemhost.py View 1 chunk +9 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/systemhost_mock.py View 2 chunks +40 lines, -27 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/print_layout_test_times.py View 1 6 chunks +52 lines, -52 lines 0 comments Download
A Tools/Scripts/webkitpy/layout_tests/print_layout_test_times_unittest.py View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
https://codereview.chromium.org/23672050/diff/1/Tools/Scripts/print-layout-test-times File Tools/Scripts/print-layout-test-times (right): https://codereview.chromium.org/23672050/diff/1/Tools/Scripts/print-layout-test-times#newcode29 Tools/Scripts/print-layout-test-times:29: # OF THIS SOFTWARE, EVEN IF ADVISED OF THE ...
7 years, 3 months ago (2013-09-19 23:50:55 UTC) #1
ojan
lgtm
7 years, 3 months ago (2013-09-20 18:22:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/23672050/5001
7 years, 3 months ago (2013-09-20 18:23:23 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 01:20:16 UTC) #4
Message was sent while issue was closed.
Change committed as 158144

Powered by Google App Engine
This is Rietveld 408576698