Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 23672029: App windows with ids should remember fullscreen state. (Closed)

Created:
7 years, 3 months ago by zhchbin
Modified:
7 years, 3 months ago
Reviewers:
scheib, sky
CC:
chromium-reviews, tfarina, scheib+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

App windows with ids should remember fullscreen state. BUG=242790 TEST=PlatformAppBrowserTest.ShellWindowRestoreState TEST=1. Install window-state-sample: https://chrome.google.com/webstore/detail/window-state-sample/hcbhfbnaaancmblfhdknlnojpafjohbi; 2. Run the app and create a new window with id. 3. Fullscreen the new window by clicking "Fullscreen" of "chrome.app.window" section; 4. Close the window (You can use "Alt+F4" etc.) and recreate the new window with the same id. 5. A fullscreen window should be shown. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/apps/native_app_window_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restore_state/test.js View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zhchbin
Please review.
7 years, 3 months ago (2013-09-09 02:08:42 UTC) #1
scheib
lgtm with a change to the change description. Please add manual testing instructions referencing https://chrome.google.com/webstore/detail/window-state-sample/hcbhfbnaaancmblfhdknlnojpafjohbi ...
7 years, 3 months ago (2013-09-09 15:29:40 UTC) #2
sky
LGTM
7 years, 3 months ago (2013-09-09 15:59:41 UTC) #3
zhchbin
On 2013/09/09 15:29:40, scheib wrote: > lgtm with a change to the change description. > ...
7 years, 3 months ago (2013-09-10 01:03:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/23672029/1
7 years, 3 months ago (2013-09-10 01:04:38 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 01:38:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/23672029/1
7 years, 3 months ago (2013-09-10 04:44:49 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 08:59:49 UTC) #8
Message was sent while issue was closed.
Change committed as 222226

Powered by Google App Engine
This is Rietveld 408576698