Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 23672025: Cancel the starvation callback when MediaSourcePlayer::Release() gets called. (Closed)

Created:
7 years, 3 months ago by qinmin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Cancel the starvation callback when MediaSourcePlayer::Release() gets called. If we don't cancel the starvation callback, ProcessPendingEvents will get executed later when the callback fires. Because we use a BarrierClosure in ProcessPendingEvents() and the count is 0 as both audio and video decoders are released, OnPrefetchDone() will be immediately called. And this will cause ProcessPendingEvents() to get called again and again, thus crashing chrome. An alternative to this fix is to check count before creating the barrier. Logically starvation callback should not get called after Release(). BUG=285573 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/base/android/media_source_player.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qinmin
PTAL
7 years, 3 months ago (2013-09-05 03:04:00 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
7 years, 3 months ago (2013-09-05 14:40:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/23672025/1
7 years, 3 months ago (2013-09-05 16:10:55 UTC) #3
xhwang
lgtm
7 years, 3 months ago (2013-09-05 16:17:20 UTC) #4
wolenetz
lgtm
7 years, 3 months ago (2013-09-05 16:30:40 UTC) #5
wolenetz
lgtm
7 years, 3 months ago (2013-09-05 16:30:43 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 20:44:03 UTC) #7
Message was sent while issue was closed.
Change committed as 221509

Powered by Google App Engine
This is Rietveld 408576698