Issue 23670006: Use DriveService for proper resource id resolution in ChangeListLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23670006: Use DriveService for proper resource id resolution in ChangeListLoader. (Closed)

Created:
7 years, 3 months ago by kinaba

Modified:
7 years, 3 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use DriveService for proper resource id resolution in ChangeListLoader. The fixture of ID is needed not only for WAPI -> DriveAPI but also for WAPI -> FakeDriveService. BUG=285614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221685

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -18 lines)			Patch
M	chrome/browser/chromeos/drive/change_list_loader.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_loader.cc	View	5 chunks	+17 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_loader_unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operation_test_base.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/23670006/1

7 years, 3 months ago (2013-09-06 09:30:57 UTC) #3

Message was sent while issue was closed.

Change committed as 221685

Expand Messages | Collapse Messages