Issue 23666007: [Android] emma_instr.py now removes any stale *.em/*sources.txt

Issue 23666007: [Android] emma_instr.py now removes any stale .em/sources.txt (Closed)

Created:
7 years, 3 months ago by frankf

Modified:
7 years, 3 months ago

Reviewers:
cjhopman, akalin

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] emma_instr.py now removes any stale *.em/*sources.txt BUG=278365 NOTRY=True TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220714

Patch Set 2 : Addressed comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -42 lines)			Patch
M	build/android/generate_emma_html.py	View	1	3 chunks	+12 lines, -27 lines	0 comments	Download
M	build/android/gyp/emma_instr.py	View	1	4 chunks	+23 lines, -11 lines	0 comments	Download
M	build/android/instr_action.gypi	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	third_party/cacheinvalidation/cacheinvalidation.gyp	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cjhopman

https://codereview.chromium.org/23666007/diff/1/build/android/generate_emma_html.py File build/android/generate_emma_html.py (right): https://codereview.chromium.org/23666007/diff/1/build/android/generate_emma_html.py#newcode66 build/android/generate_emma_html.py:66: print 'Sources: %s' % sources Note: this print is ...

7 years, 3 months ago (2013-08-30 17:59:40 UTC) #2

frankf

ptal. + akalin for third_party/cacheinvalidation https://codereview.chromium.org/23666007/diff/1/build/android/generate_emma_html.py File build/android/generate_emma_html.py (right): https://codereview.chromium.org/23666007/diff/1/build/android/generate_emma_html.py#newcode66 build/android/generate_emma_html.py:66: print 'Sources: %s' % ...

7 years, 3 months ago (2013-08-30 18:12:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/23666007/15001

7 years, 3 months ago (2013-08-31 01:16:38 UTC) #5

Message was sent while issue was closed.

Change committed as 220714

Expand Messages | Collapse Messages