Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 23664005: Adding error message to error string (Closed)

Created:
7 years, 3 months ago by vadimt
Modified:
7 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Adding error message to error string. Even though error message (like 'message' param to 'verify()') gets sent as a part of the stack, the internal crash reporter doesn't show it, probably, because it doesn't look like a frame. Adding this message to the error string. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221097

Patch Set 1 #

Total comments: 2

Patch Set 2 : arv@ notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/google_now/utility.js View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
vadimt
7 years, 3 months ago (2013-08-30 17:25:05 UTC) #1
skare_
lgtm
7 years, 3 months ago (2013-08-30 17:28:06 UTC) #2
robliao
lgtm
7 years, 3 months ago (2013-08-30 17:30:06 UTC) #3
vadimt
arv@, please provide OWNER's approval
7 years, 3 months ago (2013-08-30 17:37:21 UTC) #4
rgustafson
lgtm
7 years, 3 months ago (2013-08-30 20:09:14 UTC) #5
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/23664005/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/23664005/diff/1/chrome/browser/resources/google_now/utility.js#newcode119 chrome/browser/resources/google_now/utility.js:119: errorText = errorText + ': ' + error.message; ...
7 years, 3 months ago (2013-09-03 17:01:30 UTC) #6
vadimt
https://codereview.chromium.org/23664005/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (right): https://codereview.chromium.org/23664005/diff/1/chrome/browser/resources/google_now/utility.js#newcode119 chrome/browser/resources/google_now/utility.js:119: errorText = errorText + ': ' + error.message; On ...
7 years, 3 months ago (2013-09-03 17:58:44 UTC) #7
arv (Not doing code reviews)
Thanks LGTM
7 years, 3 months ago (2013-09-03 17:59:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/23664005/10001
7 years, 3 months ago (2013-09-03 17:59:18 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 01:00:21 UTC) #10
Message was sent while issue was closed.
Change committed as 221097

Powered by Google App Engine
This is Rietveld 408576698