Issue 23662004: Reland r221579: Files.app: Let the PreviewPanel class control the visibility of the preview panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23662004: Reland r221579: Files.app: Let the PreviewPanel class control the visibility of the preview panel. (Closed)

Created:
7 years, 3 months ago by hirono

Modified:
7 years, 3 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland r221579: Files.app: Let the PreviewPanel class control the visibility of the preview panel. Originally, PreviewPanel is not used from any code. This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel. Previously reverted CL: crrev.com/23464030 BUG=284215 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221983

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix the test. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -112 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2 3	7 chunks	+39 lines, -25 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_selection.js	View		7 chunks	+12 lines, -83 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/main_scripts.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/ui/preview_panel.js	View	1 2	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hirono

Could you check the CL? This is the reland CL of crrev.com/23464030. The original CL ...

7 years, 3 months ago (2013-09-06 10:45:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23662004/22001

7 years, 3 months ago (2013-09-09 01:04:06 UTC) #3

Message was sent while issue was closed.

Change committed as 221983

Expand Messages | Collapse Messages