Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 23661003: Explicitly list IDR resource ids in ui/views/bubble_border.cc (Closed)

Created:
7 years, 3 months ago by James Cook
Modified:
7 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina
Visibility:
Public.

Description

Explicitly list IDR resource ids in ui/views/bubble_border.cc Avoid the use of macros to construct IDR_FOO_LEFT/TOP/BOTTOM resource IDs, which makes it easier to find the IDs in the code, especially for automated tools. BUG=281716 TEST=compiles, manual inspection of bubbles on Chrome OS shelf and launcher Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M ui/views/bubble/bubble_border.cc View 1 chunk +46 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
msw, PTAL
7 years, 3 months ago (2013-08-29 21:03:56 UTC) #1
msw
lgtm
7 years, 3 months ago (2013-08-29 21:21:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/23661003/1
7 years, 3 months ago (2013-08-29 21:24:42 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 03:19:52 UTC) #4
Message was sent while issue was closed.
Change committed as 220494

Powered by Google App Engine
This is Rietveld 408576698