Issue 23658057: Simple Cache: stop running index file tests on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23658057: Simple Cache: stop running index file tests on Windows (Closed)

Created:
7 years, 3 months ago by pasko

Modified:
7 years, 3 months ago

Reviewers:
gavinp, Randy Smith (Not in Mondays)

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simple Cache: stop running index file tests on Windows Also unify the messaging and conditionalizing around OS_POSIX. Reason: swarm_triggered were mysteriously failing on a windows trybot. Get it out of the way for the important bug below. BUG=261618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223609

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
M	net/disk_cache/backend_unittest.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	net/disk_cache/entry_unittest.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/disk_cache/simple/simple_index_file_unittest.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@chromium.org/23658057/6001

7 years, 3 months ago (2013-09-17 09:25:08 UTC) #3

Message was sent while issue was closed.

Change committed as 223609

Expand Messages | Collapse Messages