Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 23658033: Reload the descriptor after modifying the transition target. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest
Modified:
7 years, 3 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Reload the descriptor after modifying the transition target. R=danno@chromium.org BUG=chromium:282736 Committed: https://code.google.com/p/v8/source/detail?r=16619

Patch Set 1 #

Patch Set 2 : Adding test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M src/objects.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-282736.js View 1 1 chunk +27 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
7 years, 3 months ago (2013-09-10 12:57:15 UTC) #1
danno
I would feel more comfortable with the patch if it had a test. :-)
7 years, 3 months ago (2013-09-10 13:08:44 UTC) #2
Toon Verwaest
Added test, PTAL again.
7 years, 3 months ago (2013-09-10 13:30:34 UTC) #3
danno
lgtm.
7 years, 3 months ago (2013-09-10 13:49:42 UTC) #4
Toon Verwaest
7 years, 3 months ago (2013-09-10 13:53:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16619 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698