Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 23658031: Implement in-place rehashing of HashTable. (Closed)

Created:
7 years, 3 months ago by ulan
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Implement in-place rehashing of HashTable. The algorithm puts elements into correct positions in multiple iterations. On the first iteration it tries to put elements at entries specified by their first hash probe. On the second iteration -- by the second hash probe, and so on. Overall it does O(k*n) memory accesses, where k is the maximum number of probes required for an element and n is the capacity of the hash table. The expectation is that k will be small. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16678

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Comment #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
M src/objects.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Please take a look.
7 years, 3 months ago (2013-09-10 12:14:14 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/23658031/diff/5001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/23658031/diff/5001/src/objects.h#newcode3469 src/objects.h:3469: void Rehash(Key key); nit: Let's add a short ...
7 years, 3 months ago (2013-09-12 09:39:16 UTC) #2
ulan
7 years, 3 months ago (2013-09-12 11:03:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698