Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: trunk/src/sync/internal_api/syncapi_server_connection_manager.h

Issue 23658030: Revert 222154 "sync: Gracefully handle very early shutdown" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/sync/internal_api/syncapi_server_connection_manager.h
===================================================================
--- trunk/src/sync/internal_api/syncapi_server_connection_manager.h (revision 222204)
+++ trunk/src/sync/internal_api/syncapi_server_connection_manager.h (working copy)
@@ -12,11 +12,9 @@
#include "base/memory/scoped_ptr.h"
#include "sync/base/sync_export.h"
#include "sync/engine/net/server_connection_manager.h"
-#include "sync/internal_api/public/base/cancelation_signal.h"
namespace syncer {
-class ConnectionDisconnectHandle;
class HttpPostProviderFactory;
class HttpPostProviderInterface;
@@ -57,16 +55,13 @@
int port,
bool use_ssl,
bool use_oauth2_token,
- HttpPostProviderFactory* factory,
- CancelationSignal* cancelation_signal);
+ HttpPostProviderFactory* factory);
virtual ~SyncAPIServerConnectionManager();
// ServerConnectionManager overrides.
- virtual scoped_ptr<Connection> MakeConnection() OVERRIDE;
+ virtual Connection* MakeConnection() OVERRIDE;
private:
- FRIEND_TEST_ALL_PREFIXES(
- SyncAPIServerConnectionManagerTest, VeryEarlyAbortPost);
FRIEND_TEST_ALL_PREFIXES(SyncAPIServerConnectionManagerTest, EarlyAbortPost);
FRIEND_TEST_ALL_PREFIXES(SyncAPIServerConnectionManagerTest, AbortPost);

Powered by Google App Engine
This is Rietveld 408576698