Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: trunk/src/sync/engine/sync_scheduler.h

Issue 23658030: Revert 222154 "sync: Gracefully handle very early shutdown" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/sync/engine/net/server_connection_manager.cc ('k') | trunk/src/sync/engine/sync_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/sync/engine/sync_scheduler.h
===================================================================
--- trunk/src/sync/engine/sync_scheduler.h (revision 222204)
+++ trunk/src/sync/engine/sync_scheduler.h (working copy)
@@ -75,9 +75,11 @@
// Note: must already be in CONFIGURATION mode.
virtual bool ScheduleConfiguration(const ConfigurationParams& params) = 0;
- // Request that the syncer avoid starting any new tasks and prepare for
- // shutdown.
- virtual void Stop() = 0;
+ // Request that any running syncer task stop as soon as possible and
+ // cancel all scheduled tasks. This function can be called from any thread,
+ // and should in fact be called from a thread that isn't the sync loop to
+ // allow preempting ongoing sync cycles.
+ virtual void RequestStop() = 0;
// The meat and potatoes. All three of the following methods will post a
// delayed task to attempt the actual nudge (see ScheduleNudgeImpl).
« no previous file with comments | « trunk/src/sync/engine/net/server_connection_manager.cc ('k') | trunk/src/sync/engine/sync_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698