Printer list for Google Cloud Print

Printer list for Google Cloud Print

Retrieves list of printers for Google Cloud Print. Lets users look up printers
by ID or iterate over all printers.

BUG=286157
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221733

[Vitaly Buka (NO REVIEWS), 2013-09-04 21:46:25]

Bug?

https://chromiumcodereview.appspot.com/23658020/diff/1/chrome/browser/local_d...
File chrome/browser/local_discovery/cloud_print_base_api_flow.cc (right):

https://chromiumcodereview.appspot.com/23658020/diff/1/chrome/browser/local_d...
chrome/browser/local_discovery/cloud_print_base_api_flow.cc:80:
separator_character,
Please use net::AppendQueryParameter(

https://chromiumcodereview.appspot.com/23658020/diff/1/chrome/browser/local_d...
File chrome/browser/local_discovery/cloud_print_printer_list.cc (right):

https://chromiumcodereview.appspot.com/23658020/diff/1/chrome/browser/local_d...
chrome/browser/local_discovery/cloud_print_printer_list.cc:95: if
(!printer_value->GetString(cloud_print::kDisplayNameValue,
misaligned and needs {}

[Noam Samuel, 2013-09-05 23:08:31]

https://codereview.chromium.org/23658020/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/cloud_print_base_api_flow.cc (right):

https://codereview.chromium.org/23658020/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/cloud_print_base_api_flow.cc:80:
separator_character,
On 2013/09/04 21:46:25, Vitaly Buka wrote:
> Please use net::AppendQueryParameter(

Done.

https://codereview.chromium.org/23658020/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/cloud_print_printer_list.cc (right):

https://codereview.chromium.org/23658020/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/cloud_print_printer_list.cc:95: if
(!printer_value->GetString(cloud_print::kDisplayNameValue,
On 2013/09/04 21:46:25, Vitaly Buka wrote:
> misaligned and needs {}

Done.

[commit-bot: I haz the power, 2013-09-06 01:11:01]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Vitaly Buka (NO REVIEWS), 2013-09-06 01:28:35]

lgtm

[commit-bot: I haz the power, 2013-09-06 01:29:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23658020/15001

[commit-bot: I haz the power, 2013-09-06 01:29:37]

Failed to apply patch for
chrome/browser/local_discovery/cloud_print_base_api_flow.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: chrome/browser/local_discovery/cloud_print_base_api_flow.h
  |diff --git a/chrome/browser/local_discovery/cloud_print_base_api_flow.h
b/chrome/browser/local_discovery/cloud_print_base_api_flow.h
  |index
e6f004cc4648dd099ae3c17af6ab034a1f76ec12..b60ecf1d766c9da6c44a0c15882007cbf2936b04
100644
  |--- a/chrome/browser/local_discovery/cloud_print_base_api_flow.h
  |+++ b/chrome/browser/local_discovery/cloud_print_base_api_flow.h
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       chrome/browser/local_discovery/cloud_print_base_api_flow.h
Index: chrome/browser/local_discovery/cloud_print_base_api_flow.h
diff --git a/chrome/browser/local_discovery/cloud_print_base_api_flow.h
b/chrome/browser/local_discovery/cloud_print_base_api_flow.h
index
e6f004cc4648dd099ae3c17af6ab034a1f76ec12..b60ecf1d766c9da6c44a0c15882007cbf2936b04
100644
--- a/chrome/browser/local_discovery/cloud_print_base_api_flow.h
+++ b/chrome/browser/local_discovery/cloud_print_base_api_flow.h
@@ -77,8 +77,11 @@ class CloudPrintBaseApiFlow : public net::URLFetcherDelegate,
   virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
                                  const GoogleServiceAuthError& error) OVERRIDE;
 
+  // Return the user index or kAccountIndexUseOAuth2 if none is available.
+  int user_index() { return user_index_; }
+
  private:
-  bool UseOAuth2() { return token_service_ != NULL; }
+  bool UseOAuth2() { return user_index_ == kAccountIndexUseOAuth2; }
 
   void CreateRequest(const GURL& url);

[commit-bot: I haz the power, 2013-09-06 06:50:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23658020/15001

[commit-bot: I haz the power, 2013-09-06 09:07:08]

Retried try job too often on linux_chromeos for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-06 16:59:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23658020/15001

[commit-bot: I haz the power, 2013-09-06 17:44:40]

Change committed as 221733