Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23657002: Ensure class mirrors on non-generic classes always have their runtime type set. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase, expand equality coverage Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 62e72d972f7711eb73b4d897dd16c1f5324fd459..ddf05f0b479aa7aca42051136c7ff83eb154d10d 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -283,6 +283,7 @@ class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl
identical(_reflectee, other._reflectee);
}
+ // TODO(12909): Use the reflectee's identity hash.
int get hashCode => _reflectee.hashCode;
_invoke(reflectee, functionName, positionalArguments)
@@ -629,8 +630,7 @@ class _LocalClassMirrorImpl extends _LocalObjectMirrorImpl
bool operator ==(other) {
return this.runtimeType == other.runtimeType &&
this._reflectee == other._reflectee &&
- (isOriginalDeclaration ||
- this._reflectedType == other._reflectedType);
+ this._reflectedType == other._reflectedType;
}
int get hashCode => simpleName.hashCode;
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698