Materialized the font/icon color for some default rows in the system menu.

Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth
- SMS
- Tracing
- Network

BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027
Committed: https://crrev.com/d4bf12487e9894b8a523e9bcaf3bf69003c254bf
Cr-Commit-Position: refs/heads/master@{#420689}

[bruthig, 2016-09-22 00:57:11]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 00:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 01:50:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 01:50:47]

Dry run: This issue passed the CQ dry run.

[bruthig, 2016-09-22 15:01:01]

Description was changed from

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth

BUG=638321, 632147, 632114, 632040, 632023, TODO-add bluetooth bug
==========

to

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth

BUG=638321, 632147, 632114, 632040, 632023, 632129
==========

[bruthig, 2016-09-22 16:08:00]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 16:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-09-22 16:08:26]

Description was changed from

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth

BUG=638321, 632147, 632114, 632040, 632023, 632129
==========

to

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth
- SMS
- Tracing
- Network

BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027
==========

[bruthig, 2016-09-22 16:08:53]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-09-22 16:08:54]

Terry, can you PTAL?

[commit-bot: I haz the power, 2016-09-22 17:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:04:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tdanderson, 2016-09-22 20:44:17]

lgtm with comments

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
File ash/common/system/chromeos/network/tray_vpn.cc (right):

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
ash/common/system/chromeos/network/tray_vpn.cc:127: if (!IsVpnConnected()) {
Thanks for the cleanup.

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
File ash/common/system/tray/tray_item_more.cc (right):

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
ash/common/system/tray/tray_item_more.cc:74: GetNativeTheme(),
TrayPopupItemStyle::FontStyle::TITLE);
Maybe return DEFAULT_VIEW_LABEL by default?

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
File ash/common/system/tray/tray_item_more.h (right):

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
ash/common/system/tray/tray_item_more.h:40: // TODO(bruthig) Document me.
Can you add some documentation (here and perhaps something for CreateStyle()?

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
File ash/common/system/tray/tray_popup_item_style.h (right):

https://chromiumcodereview.appspot.com/2365523002/diff/20001/ash/common/syste...
ash/common/system/tray/tray_popup_item_style.h:24: class TrayPopupItemStyle {
As discussed in person, perhaps include some commentary about proper use?

[bruthig, 2016-09-22 21:45:49]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:46:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-09-22 21:47:21]

bruthig@chromium.org changed reviewers:
+ sky@chromium.org

[bruthig, 2016-09-22 21:47:22]

sky@, can you please take a quick look at:

- ash/BUILD.gn
- ash/system/chromeos/rotation/tray_rotation_lock.cc

https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_item_more.cc (right):

https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_item_more.cc:74: GetNativeTheme(),
TrayPopupItemStyle::FontStyle::TITLE);
On 2016/09/22 20:44:16, tdanderson wrote:
> Maybe return DEFAULT_VIEW_LABEL by default?

Good call, originally I was thinking TrayItemMore was used in other places than
the default views and I wanted it to be set explicitly.

https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_item_more.h (right):

https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_item_more.h:40: // TODO(bruthig) Document me.
On 2016/09/22 20:44:16, tdanderson wrote:
> Can you add some documentation (here and perhaps something for CreateStyle()?

Done.  WDYT?

https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_popup_item_style.h (right):

https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_popup_item_style.h:24: class TrayPopupItemStyle {
On 2016/09/22 20:44:16, tdanderson wrote:
> As discussed in person, perhaps include some commentary about proper use?

Done.  WDYT?

[commit-bot: I haz the power, 2016-09-22 22:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:51:34]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-23 15:45:34]

LGTM

[tdanderson, 2016-09-23 15:50:53]

On 2016/09/22 21:47:22, bruthig (OOO Sep 23-28) wrote:
> sky@, can you please take a quick look at:
> 
> - ash/BUILD.gn
> - ash/system/chromeos/rotation/tray_rotation_lock.cc
> 
>
https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
> File ash/common/system/tray/tray_item_more.cc (right):
> 
>
https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
> ash/common/system/tray/tray_item_more.cc:74: GetNativeTheme(),
> TrayPopupItemStyle::FontStyle::TITLE);
> On 2016/09/22 20:44:16, tdanderson wrote:
> > Maybe return DEFAULT_VIEW_LABEL by default?
> 
> Good call, originally I was thinking TrayItemMore was used in other places
than
> the default views and I wanted it to be set explicitly.
> 
>
https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
> File ash/common/system/tray/tray_item_more.h (right):
> 
>
https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
> ash/common/system/tray/tray_item_more.h:40: // TODO(bruthig) Document me.
> On 2016/09/22 20:44:16, tdanderson wrote:
> > Can you add some documentation (here and perhaps something for
CreateStyle()?
> 
> Done.  WDYT?
> 
>
https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
> File ash/common/system/tray/tray_popup_item_style.h (right):
> 
>
https://codereview.chromium.org/2365523002/diff/20001/ash/common/system/tray/...
> ash/common/system/tray/tray_popup_item_style.h:24: class TrayPopupItemStyle {
> On 2016/09/22 20:44:16, tdanderson wrote:
> > As discussed in person, perhaps include some commentary about proper use?
> 
> Done.  WDYT?

New documentation lgtm, thanks!

[bruthig, 2016-09-23 19:07:34]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:08:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:13:53]

Description was changed from

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth
- SMS
- Tracing
- Network

BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027
==========

to

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth
- SMS
- Tracing
- Network

BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027
==========

[commit-bot: I haz the power, 2016-09-23 19:13:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 19:16:08]

Description was changed from

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth
- SMS
- Tracing
- Network

BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027
==========

to

==========
Materialized the font/icon color for some default rows in the system menu.

List of materialized rows:
- IME
- OS update
- VPN
- Accessibility
- Rotation lock
- Bluetooth
- SMS
- Tracing
- Network

BUG=638321, 632147, 632114, 632040, 632023, 632129, 632027

Committed: https://crrev.com/d4bf12487e9894b8a523e9bcaf3bf69003c254bf
Cr-Commit-Position: refs/heads/master@{#420689}
==========

[commit-bot: I haz the power, 2016-09-23 19:16:09]

Patchset 3 (id:??) landed as
https://crrev.com/d4bf12487e9894b8a523e9bcaf3bf69003c254bf
Cr-Commit-Position: refs/heads/master@{#420689}