Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: ui/aura/window.cc

Issue 23654037: Add panels as a single group of windows per display for overview window cycling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index 6053c0be43970a6441f4ef423f2701389b66812e..f03f352807f13a7b5f67f1a80a406a22677f45d6 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -702,8 +702,12 @@ void Window::SetBoundsInternal(const gfx::Rect& new_bounds) {
}
void Window::SetVisible(bool visible) {
- if (visible == layer_->GetTargetVisibility())
+ if (visible == layer_->GetTargetVisibility()) {
+ // After calling SetVisible, IsVisible should immediately return the target
+ // visibility state.
sky 2013/09/13 21:46:44 I think this is wrong. The reason you're seeing th
flackr 2013/09/13 22:28:38 I should provide some context. PanelLayoutManager:
sky 2013/09/16 17:03:35 725 updates visibility, so how come PanelLayoutMan
+ visible_ = visible;
return; // No change.
+ }
FOR_EACH_OBSERVER(WindowObserver, observers_,
OnWindowVisibilityChanging(this, visible));

Powered by Google App Engine
This is Rietveld 408576698