Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Issue 23654035: Rename AudioInputDeviceTest to AudioManagerTest since that is what it tests. (Closed)

Created:
7 years, 3 months ago by Jói
Modified:
7 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enumAll
Visibility:
Public.

Description

Rename AudioInputDeviceTest to AudioManagerTest. That is the interface it tests. TBR=vrk@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223598

Patch Set 1 #

Patch Set 2 : Merge parent and LKGR. #

Patch Set 3 : Merge to head. #

Patch Set 4 : Fix friend declaration to fix Win build. #

Patch Set 5 : Another friend fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -364 lines) Patch
D media/audio/audio_input_device_unittest.cc View 1 chunk +0 lines, -345 lines 0 comments Download
A + media/audio/audio_manager_unittest.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/wavein_input_win.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Jói
7 years, 3 months ago (2013-09-12 14:08:06 UTC) #1
tommi (sloooow) - chröme
lgtm
7 years, 3 months ago (2013-09-12 20:43:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/23654035/1
7 years, 3 months ago (2013-09-12 20:48:54 UTC) #3
commit-bot: I haz the power
Failed to apply patch for media/audio/audio_manager_unittest.cc: File exist but was about to be overwriten Patch: ...
7 years, 3 months ago (2013-09-12 20:48:56 UTC) #4
Jói
TBR=vrk@chromium.org for rename of one unit test source file in media.gyp
7 years, 3 months ago (2013-09-16 15:42:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/23654035/10001
7 years, 3 months ago (2013-09-16 15:44:03 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-16 16:42:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/23654035/31001
7 years, 3 months ago (2013-09-17 07:56:05 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-17 09:13:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/23654035/56001
7 years, 3 months ago (2013-09-17 09:46:26 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 13:02:09 UTC) #11
Message was sent while issue was closed.
Change committed as 223598

Powered by Google App Engine
This is Rietveld 408576698